refactor tests

tests/test_health.py

@@ -43,7 +43,7 @@ async def test_liveness_does_not_depend_on_runtime_providers() -> None:
 
 
 @pytest.mark.parametrize(
-    ("provider_ready", "status_code", "payload"),
+    ("provider_result", "status_code", "payload"),
     [
         (True, 200, {"status": "ready"}),
         (
@@ -54,24 +54,24 @@ async def test_liveness_does_not_depend_on_runtime_providers() -> None:
                 "reason": "opencode provider is not connected",
             },
         ),
+        pytest.param(
+            RuntimeError("provider check failed"),
+            500,
+            None,
+            id="provider-error",
+        ),
     ],
 )
 async def test_readiness_reflects_provider_state(
-    provider_ready: bool, status_code: int, payload: dict[str, str]
+    provider_result: bool | Exception,
+    status_code: int,
+    payload: dict[str, str] | None,
 ) -> None:
-    provider = Provider(provider_ready)
+    provider = Provider(provider_result)
 
     response = await get(application(provider), "/health/ready")
 
     assert response.status_code == status_code
-    assert response.json() == payload
-    assert provider.calls == 1
-
-
-async def test_readiness_provider_error_is_server_failure() -> None:
-    provider = Provider(RuntimeError("provider check failed"))
-
-    response = await get(application(provider), "/health/ready")
-
-    assert response.status_code == 500
+    if payload is not None:
+        assert response.json() == payload
     assert provider.calls == 1