feat: make playwright optional
CI / verify (pull_request) Successful in 8s

This commit is contained in:
2026-09-15 10:18:43 +02:00
parent 1bc5c329a8
commit f6cae21bfa
8 changed files with 93 additions and 14 deletions
+12
View File
@@ -199,6 +199,18 @@ test("reinstall replaces bundles while preserving existing settings and plugin o
expect(await readFile(join(setup.installed, "index.js"), "utf8")).toContain('return "second"');
});
test("enables Playwright only when requested", async () => {
const setup = await fixture();
const result = await run(
["bash", join(setup.checkout, "install-local.sh"), "--playwright"],
setup.cwd,
setup.env,
);
expect(result, result.stderr).toMatchObject({ exitCode: 0 });
const installed = JSON.parse(await readFile(join(setup.config, "opencode.json"), "utf8"));
expect(installed.plugins.at(-1).options.playwright).toBe(true);
});
for (const mode of ["dependency", "build", "validation", "config"] as const) {
test(`${mode} failure leaves the previous installation and configuration untouched`, async () => {
const invalidConfig = mode === "config" ? { plugins: "not-an-array" } : undefined;
+17 -2
View File
@@ -44,7 +44,11 @@ async function run(command: string[], cwd: string, env: NodeJS.ProcessEnv) {
return { exitCode, stdout, stderr };
}
async function install(mode: "native" | "checksum" | "legacy", configured = false) {
async function install(
mode: "native" | "checksum" | "legacy",
configured = false,
playwright = false,
) {
const directory = await mkdtemp(join(tmpdir(), "stanp-install-"));
directories.push(directory);
const config =
@@ -187,7 +191,11 @@ exec sha256sum "$@"
),
]);
await Promise.all([chmod(join(bin, "curl"), 0o755), chmod(join(bin, "sha256sum"), 0o755)]);
const result = await run(["bash", installer], directory, env);
const result = await run(
["bash", installer, ...(playwright ? ["--playwright"] : [])],
directory,
env,
);
return { directory, config, env, result };
}
@@ -249,6 +257,13 @@ test("preserves an existing stanp-opencode configuration", async () => {
expect(installed.permissions).toEqual(jsonConfig.permissions);
}, 60_000);
test("enables Playwright only when requested", async () => {
const { config, result } = await install("native", false, true);
expect(result, result.stderr).toMatchObject({ exitCode: 0 });
const installed = JSON.parse(await readFile(join(config, "opencode.json"), "utf8"));
expect(installed.plugins.at(-1).options.playwright).toBe(true);
}, 60_000);
for (const mode of ["checksum", "legacy"] as const) {
test(`${mode} failure preserves the installed plugin in a custom path containing spaces`, async () => {
const { directory, config, env, result } = await install(mode);
+18 -3
View File
@@ -442,7 +442,13 @@ test("playwright MCP prefers direct MCP, uses npx for Playwright, and preserves
await writeFile(executable, "#!/usr/bin/env node\n");
await chmod(executable, 0o755);
const local = await host(allModels, { provider: "test" }, {}, [], localProject);
const local = await host(
allModels,
{ provider: "test", playwright: true },
{},
[],
localProject,
);
expect(local.mcpServers.get("playwright")).toEqual({
type: "local",
command: [executable],
@@ -475,7 +481,13 @@ test("playwright MCP prefers direct MCP, uses npx for Playwright, and preserves
);
await writeFile(ordinaryExecutable, "#!/usr/bin/env node\n");
await chmod(ordinaryExecutable, 0o755);
const ordinary = await host(allModels, { provider: "test" }, {}, [], ordinaryProject);
const ordinary = await host(
allModels,
{ provider: "test", playwright: true },
{},
[],
ordinaryProject,
);
expect(ordinary.mcpServers.get("playwright")?.command).toEqual([
"npx",
"-y",
@@ -534,7 +546,7 @@ test("playwright MCP prefers direct MCP, uses npx for Playwright, and preserves
await chmod(fakePlaywright, 0o755);
expect((await playwrightMcpCommand(globalProject, ordinaryBin))[0]).toBe("docker");
const fallback = await host();
const fallback = await host(allModels, { provider: "test", playwright: true });
expect(fallback.mcpServers.get("playwright")).toEqual({
type: "local",
command: ["docker", "run", "-i", "--rm", "--init", "mcr.microsoft.com/playwright/mcp"],
@@ -561,6 +573,9 @@ test("playwright MCP prefers direct MCP, uses npx for Playwright, and preserves
timeout: { startup: 12_345 },
});
expect(existing.mcpServers.get("docs")?.codemode).toBe(true);
const disabled = await host();
expect(disabled.mcpServers.has("playwright")).toBe(false);
} finally {
if (originalPath === undefined) delete process.env.PATH;
else process.env.PATH = originalPath;